Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set proper default for exclude_http_methods in auth middleware #2325

Merged
merged 5 commits into from
Sep 22, 2023
Merged

fix: set proper default for exclude_http_methods in auth middleware #2325

merged 5 commits into from
Sep 22, 2023

Conversation

guacs
Copy link
Member

@guacs guacs commented Sep 21, 2023

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR

Description

  • This PR sets OPTIONS as the default value for exclude_http_methods in the base authentication middleware class.

Close Issue(s)

@guacs guacs requested review from a team as code owners September 21, 2023 04:50
@sobolevn sobolevn mentioned this pull request Sep 21, 2023
Merged
@guacs guacs force-pushed the middlware-default-exclude-methods branch from ec612d7 to 62ad67f Compare September 22, 2023 15:50
@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2325

@guacs guacs merged commit 768fc2e into main Sep 22, 2023
18 checks passed
@guacs guacs deleted the middlware-default-exclude-methods branch September 22, 2023 16:00
@guacs guacs mentioned this pull request Sep 26, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@euri10 euri10 euri10 left review comments

@provinzkraut provinzkraut provinzkraut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: OPTIONS getting 401 Error with custom AuthMiddleware
3 participants
@guacs @euri10 @provinzkraut