feat: Support Pydantic 1 and 2 within the same application #2487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Janek Nouvertné <25355197+provinzkraut@users.noreply.github.com>
Signed-off-by: Janek Nouvertné <25355197+provinzkraut@users.noreply.github.com>
Signed-off-by: Janek Nouvertné <25355197+provinzkraut@users.noreply.github.com>
Signed-off-by: Janek Nouvertné <25355197+provinzkraut@users.noreply.github.com>
Signed-off-by: Janek Nouvertné <25355197+provinzkraut@users.noreply.github.com>
Signed-off-by: Janek Nouvertné <25355197+provinzkraut@users.noreply.github.com>
Signed-off-by: Janek Nouvertné <25355197+provinzkraut@users.noreply.github.com>
Signed-off-by: Janek Nouvertné <25355197+provinzkraut@users.noreply.github.com>
Signed-off-by: Janek Nouvertné <25355197+provinzkraut@users.noreply.github.com>
Signed-off-by: Janek Nouvertné <25355197+provinzkraut@users.noreply.github.com>
Signed-off-by: Janek Nouvertné <25355197+provinzkraut@users.noreply.github.com>
provinzkraut
commented
Oct 22, 2023
…refactored) (#2489) 'Refactored by Sourcery' Co-authored-by: Sourcery AI <>
provinzkraut
commented
Oct 22, 2023
provinzkraut
commented
Oct 22, 2023
provinzkraut
commented
Oct 22, 2023
provinzkraut
commented
Oct 22, 2023
Signed-off-by: Janek Nouvertné <25355197+provinzkraut@users.noreply.github.com>
Signed-off-by: Janek Nouvertné <25355197+provinzkraut@users.noreply.github.com>
provinzkraut
force-pushed
the
pydantic-v1-v2
branch
from
6e544e4
to
507f055
Compare
guacs
reviewed
Oct 22, 2023
Signed-off-by: Janek Nouvertné <25355197+provinzkraut@users.noreply.github.com>
provinzkraut
force-pushed
the
pydantic-v1-v2
branch
from
0c7589c
to
a4b5c56
Compare
provinzkraut
commented
Oct 23, 2023
peterschutt
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Huge effort! LGTM.
My only concern is we aren't actually testing anywhere with actual v1.10 installed and v2 not installed. What do you think about making another acceptance test that tests a light pydantic v1 only application alongside our minimal app test in the publish CI? Just to trap any major stuff like import errors before a release?
guacs
reviewed
Oct 23, 2023
Co-authored-by: Peter Schutt <peter.github@proton.me>
Co-authored-by: Peter Schutt <peter.github@proton.me>
Signed-off-by: Janek Nouvertné <25355197+provinzkraut@users.noreply.github.com>
Signed-off-by: Janek Nouvertné <25355197+provinzkraut@users.noreply.github.com>
Signed-off-by: Janek Nouvertné <25355197+provinzkraut@users.noreply.github.com>
Signed-off-by: Janek Nouvertné <25355197+provinzkraut@users.noreply.github.com>
Signed-off-by: Janek Nouvertné <25355197+provinzkraut@users.noreply.github.com>
Signed-off-by: Janek Nouvertné <25355197+provinzkraut@users.noreply.github.com>
Signed-off-by: Janek Nouvertné <25355197+provinzkraut@users.noreply.github.com>
Signed-off-by: Janek Nouvertné <25355197+provinzkraut@users.noreply.github.com>
|
This PR will bring down coverage a bit, as a lot of previously uncovered code will now be included in the coverage report. This should be addressed, but I didn't want to blow up this PR even more. |
|
SonarCloud Quality Gate failed.
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2487 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support Pydantic 1 and 2 by making use of its backwards compatibility layer; Pydantic 2 ships with version 1 in the
pydantic.v1namespace. This allows us to support either both 1 & 2 if version 2 is installed or just version 1 if version 1 is installed.In addition, this also simplifies our testing setup somewhat, as we can test for both Pydantic 1 & 2 without having to re-install dependencies.
Closes
Closes #2419