Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ExceptionHandler type. #2533

Merged
merged 1 commit into from Oct 26, 2023
Merged

fix: ExceptionHandler type. #2533

merged 1 commit into from Oct 26, 2023

Conversation

peterschutt
Copy link
Contributor

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
  • Pre-Commit Checks were ran and passed
  • Tests were ran and passed

Description

Modifies the definition to use a TypeVar bound to Exception so that these callables can be annotated to receive Exception subclasses.

Close Issue(s)

Closes #2520

Modifies the definition to use a `TypeVar` bound to `Exception` so that these callables can be annotated to receive `Exception` subclasses.

Closes #2520
@peterschutt peterschutt requested review from a team as code owners October 26, 2023 23:05
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2533

@peterschutt peterschutt merged commit 6dab00e into main Oct 26, 2023
22 checks passed
@peterschutt peterschutt deleted the 2520-exceptionhandler-type branch October 26, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: allow custom exception types in the ExceptionHandlersMap and ExceptionHandler type
2 participants