New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: OpenaAPI handle tuple with ellipsis annotation #2552

Merged

peterschutt merged 1 commit into main from 2460-openapi-ellipsis

Oct 28, 2023

Contributor

peterschutt commented Oct 28, 2023

Pull Request Checklist

New code has 100% test coverage
(If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
(If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
Pre-Commit Checks were ran and passed
Tests were ran and passed

Description

PR fixes issue where we were treating an annotation such as tuple[int, ...] same as a heterogeneous tuple like tuple[int, str].

Close Issue(s)

Closes #2460


          fix: handle tuple ellipsis annotation.

4ceed4c

Closes #2460

peterschutt requested review from a team as code owners

October 28, 2023 02:23

peterschutt changed the title ~~fix: handle tuple ellipsis annotation.~~ fix: OpenaAPI handle tuple with ellipsis annotation

sonarcloud bot commented Oct 28, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

github-actions bot commented Oct 28, 2023

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2552

cofin approved these changes

View reviewed changes

Member

cofin left a comment

lgtm

peterschutt merged commit 5f0cb6a into main

18 checks passed

peterschutt deleted the 2460-openapi-ellipsis branch

October 28, 2023 05:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment