fix: no signature model data validation if DTO #2854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By the time the signature model is parsed, the DTO has already validated and built the object to be injected as `data`, so we don't need the signature model to do it again. This PR ensures that `data` fields are typed as `Any` on the signature model so that validation doesn't occur twice. This is a regression introduced in #2088, so I've added an explicit test for it. Closes #2149
peterschutt
force-pushed
the
2149-dto-data-sig-type-any
branch
from
42abfcc
to
27fa9f1
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/2854 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By the time the signature model is parsed, the DTO has already validated and built the object to be injected as
data, so we don't need the signature model to do it again.This PR ensures that
datafields are typed asAnyon the signature model so that validation doesn't occur twice.This is a regression introduced in #2088, so I've added an explicit test for it.
Closes #2149