Enhancement: OpenTelemetry integration #180 #293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterschutt
reviewed
Jul 20, 2022
| ) | ||
|
|
||
|
|
||
| def _get_route_details( |
There was a problem hiding this comment.
Any thoughts on a work around? Could we use scope["state"]?
|
What do you use for ingestion? I might have a crack at getting the template app feeding into something like https://signoz.io/ |
|
Signoz is the one that I see often. I think it's specifically for APM. I'd also like to try prometheus. |
|
I'm going to close this and re-work the implementation. I'll open a new PR once it's ready. |
|
@cofin is there anything fundamentally wrong in the implementation that is in the closed PR? It looks quite ok to me... Just wondering if you had a completely different idea on how to implement this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhancement enabled Open Telemetry integration. It is set up very similar to the Compression backend.
To use, set
instrumentation_config=InstrumentationConfig( backend='opentelemetry', excluded_urls="/test_path" ),in the Starlite application config.To do:
import-errorgetting thrown.