Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed duplicated type hints #3002

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

rosstitmarsh
Copy link
Contributor

Removes unnecessarily repeated Nones in type unions introduced in 619cafb.

@rosstitmarsh rosstitmarsh requested review from a team as code owners January 20, 2024 23:48
@cofin
Copy link
Member

cofin commented Jan 21, 2024

@all-contributors, add @rosstitmarsh for code

Copy link
Member

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

Copy link
Member

@guacs guacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@guacs guacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rosstitmarsh could you set the target branch to main?

@provinzkraut
Copy link
Member

@all-contributors add @rosstitmarsh for code

Copy link
Contributor

@provinzkraut

I've put up a pull request to add @rosstitmarsh! 🎉

@provinzkraut provinzkraut merged commit 1af7610 into litestar-org:main Jan 21, 2024
14 checks passed
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3002

@rosstitmarsh rosstitmarsh deleted the refactor-type-hints branch January 21, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants