feat: sanitize Piccolo columns with secret=True from PydanticDTO output #3030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickneise
changed the title
provinzkraut
approved these changes
Jan 26, 2024
provinzkraut
force-pushed
the
sanitize_secret_columns
branch
from
27f8fef
to
c317ec4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3030 +/- ##
========================================
Coverage 98.26% 98.26%
========================================
Files 317 317
Lines 14273 14274 +1
Branches 2458 2458
========================================
+ Hits 14025 14026 +1
Misses 107 107
Partials 141 141 ☔ View full report in Codecov by Sentry. |
|
@all-contributors add @patrickneise for code |
|
I've put up a pull request to add @patrickneise! 🎉 |
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3030 |
provinzkraut
pushed a commit
that referenced
this pull request
Jan 26, 2024
…ut (#3030) * feature(piccolo): sanitize columns with from PydanticDTO output * feature(piccolo): modify logic to assign to secret columns --------- Co-authored-by: Patrick Neise <neise.patrick@solute.us>
provinzkraut
pushed a commit
that referenced
this pull request
Jan 27, 2024
…ut (#3030) * feature(piccolo): sanitize columns with from PydanticDTO output * feature(piccolo): modify logic to assign to secret columns --------- Co-authored-by: Patrick Neise <neise.patrick@solute.us>
provinzkraut
pushed a commit
that referenced
this pull request
Feb 3, 2024
…ut (#3030) * feature(piccolo): sanitize columns with from PydanticDTO output * feature(piccolo): modify logic to assign to secret columns --------- Co-authored-by: Patrick Neise <neise.patrick@solute.us>
provinzkraut
pushed a commit
that referenced
this pull request
Feb 3, 2024
…ut (#3030) * feature(piccolo): sanitize columns with from PydanticDTO output * feature(piccolo): modify logic to assign to secret columns --------- Co-authored-by: Patrick Neise <neise.patrick@solute.us>
provinzkraut
pushed a commit
that referenced
this pull request
Feb 4, 2024
…ut (#3030) * feature(piccolo): sanitize columns with from PydanticDTO output * feature(piccolo): modify logic to assign to secret columns --------- Co-authored-by: Patrick Neise <neise.patrick@solute.us>
provinzkraut
pushed a commit
that referenced
this pull request
Feb 6, 2024
…ut (#3030) * feature(piccolo): sanitize columns with from PydanticDTO output * feature(piccolo): modify logic to assign to secret columns --------- Co-authored-by: Patrick Neise <neise.patrick@solute.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
For Picollo columns with
secret=Trueset, mark those columns asWRITE_ONLYto prevent the column being included inreturn_dto.Close Issue(s)
Closes #2976