fix(pydantic): OpenAPI schema generation for Pydantic private attributes (#3150) #3151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3151 +/- ##
==========================================
- Coverage 98.26% 98.23% -0.03%
==========================================
Files 320 320
Lines 14417 14427 +10
Branches 2319 2323 +4
==========================================
+ Hits 14167 14173 +6
- Misses 109 113 +4
Partials 141 141 ☔ View full report in Codecov by Sentry. |
provinzkraut
force-pushed
the
fix-pydantic-private-attribute-access
branch
from
5206da6
to
9e064ef
Compare
provinzkraut
force-pushed
the
fix-pydantic-private-attribute-access
branch
from
e2439c8
to
83b6088
Compare
provinzkraut
force-pushed
the
fix-pydantic-private-attribute-access
branch
from
02018b6
to
61628a8
Compare
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3151 |
guacs
approved these changes
Mar 2, 2024
euri10
pushed a commit
to euri10/litestar
that referenced
this pull request
Mar 4, 2024
…tes (litestar-org#3150) (litestar-org#3151) * Fix OpenAPI schema generation for Pydantic v2 constrained secrets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug that caused a
NameErrorwhen trying to resolve forward references in Pydantic private fields.Although we respected private fields in Pydantic and didn't include them in the schema, we still tried to extract their type annotation. This was fixed by not relying on
typing.get_type_hintsto get the type information, but instead using Pydantic's own APIs, allowing us to only extract information about the types of fields we're interested in.Fixes #3150.