Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sending empty data in sse in js client #3176

Merged
merged 1 commit into from Mar 8, 2024

Conversation

euri10
Copy link
Contributor

@euri10 euri10 commented Mar 7, 2024

Description

The added app is just to manually test the fix works, I dont know how we could incorporate it in our test suite given it involves running a server and checkin if the html page yields the event fine, maybe in e2e testing ?

@euri10 euri10 requested review from a team as code owners March 7, 2024 10:17
Copy link
Member

@provinzkraut provinzkraut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought, something like this would be good to test end-to-end with a headless browser. @euri10 wdyt?

@provinzkraut provinzkraut enabled auto-merge (squash) March 8, 2024 17:31
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.23%. Comparing base (1fb981d) to head (8e5682a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3176      +/-   ##
==========================================
- Coverage   98.23%   98.23%   -0.01%     
==========================================
  Files         320      320              
  Lines       14425    14431       +6     
  Branches     2322     2324       +2     
==========================================
+ Hits        14171    14176       +5     
  Misses        113      113              
- Partials      141      142       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@provinzkraut provinzkraut merged commit 65efff1 into litestar-org:main Mar 8, 2024
19 checks passed
Copy link

github-actions bot commented Mar 8, 2024

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3176

@JacobCoffee
Copy link
Member

@provinzkraut how would we do this?

@provinzkraut
Copy link
Member

Probably with playwright or something.

@euri10
Copy link
Contributor Author

euri10 commented Mar 9, 2024

I'm all for it but it seems sse is not supported: microsoft/playwright#7466
this is the best I came upwith and it sends error
see #3183

@euri10 euri10 deleted the sse_data_none branch March 9, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants