fix: kwarg ambiguity exc msg for path params #3261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR cherry picks @guacs' commit that fixes the way we construct the exception message when there is a kwarg ambiguity detected for path parameters. Adds a test.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3261 +/- ##
=======================================
Coverage 98.22% 98.23%
=======================================
Files 320 320
Lines 14447 14447
Branches 2297 2296 -1
=======================================
+ Hits 14191 14192 +1
Misses 114 114
+ Partials 142 141 -1 ☔ View full report in Codecov by Sentry. |
JacobCoffee
approved these changes
Mar 27, 2024
Co-authored-by: Jacob Coffee <jacob@z7x.org>
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3261 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cherry picks @guacs' commit from #3223 that fixes the way we construct the exception message when there is a kwarg ambiguity detected for path parameters.
Closes