refactor!: Remove deprecated StaticFileConfig
#3357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cofin
approved these changes
Apr 9, 2024
|
Could you potentially wait and rebase against main or #3358 before doing remaining docs-related tings? no big deal if not |
peterschutt
approved these changes
Apr 9, 2024
provinzkraut
force-pushed
the
remove-static-files-app
branch
from
0c4c32b
to
d88c1d1
Compare
github-actions
bot
added
area/contrib
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3.0 #3357 +/- ##
==========================================
- Coverage 98.28% 98.24% -0.04%
==========================================
Files 323 321 -2
Lines 14773 14687 -86
Branches 2345 2334 -11
==========================================
- Hits 14519 14429 -90
Misses 116 116
- Partials 138 142 +4 ☔ View full report in Codecov by Sentry. |
provinzkraut
force-pushed
the
remove-static-files-app
branch
from
263c4c2
to
cec9396
Compare
|
The codecov report is expected since this is bringing overall coverage down percentage wise, by deleting a bunch of code but not adding new tests. |
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3357 |
provinzkraut
added a commit
that referenced
this pull request
Apr 13, 2024
* Remove deprecated StaticFiles and StaticFilesConfig * remove special casing of static files app from handlers/router * remove outdated docs sections * Add what's new section * Rename tests for consistency
provinzkraut
added a commit
that referenced
this pull request
Apr 20, 2024
* Remove deprecated StaticFiles and StaticFilesConfig * remove special casing of static files app from handlers/router * remove outdated docs sections * Add what's new section * Rename tests for consistency
provinzkraut
added a commit
that referenced
this pull request
Apr 21, 2024
* Remove deprecated StaticFiles and StaticFilesConfig * remove special casing of static files app from handlers/router * remove outdated docs sections * Add what's new section * Rename tests for consistency
provinzkraut
added a commit
that referenced
this pull request
Apr 27, 2024
* Remove deprecated StaticFiles and StaticFilesConfig * remove special casing of static files app from handlers/router * remove outdated docs sections * Add what's new section * Rename tests for consistency
provinzkraut
added a commit
that referenced
this pull request
Apr 27, 2024
* Remove deprecated StaticFiles and StaticFilesConfig * remove special casing of static files app from handlers/router * remove outdated docs sections * Add what's new section * Rename tests for consistency
provinzkraut
added a commit
that referenced
this pull request
Apr 28, 2024
* Remove deprecated StaticFiles and StaticFilesConfig * remove special casing of static files app from handlers/router * remove outdated docs sections * Add what's new section * Rename tests for consistency
provinzkraut
added a commit
that referenced
this pull request
May 25, 2024
* Remove deprecated StaticFiles and StaticFilesConfig * remove special casing of static files app from handlers/router * remove outdated docs sections * Add what's new section * Rename tests for consistency
provinzkraut
added a commit
that referenced
this pull request
May 26, 2024
* Remove deprecated StaticFiles and StaticFilesConfig * remove special casing of static files app from handlers/router * remove outdated docs sections * Add what's new section * Rename tests for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the deprecated
static_files_configand friends.(please don't merge yet, this needs some docs and a better description 🙂)