-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: removes deprecated OpenAPIController #3360
Conversation
847a507
to
530d068
Compare
This PR removes all deprecated elements of OpenAPIConfig and the OpenAPIController, removes any obsolete tests and refactors tests that were parametrized to test both OpenAPIController and the router-based approach.
530d068
to
acccd61
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3.0 #3360 +/- ##
==========================================
- Coverage 98.24% 98.23% -0.01%
==========================================
Files 321 320 -1
Lines 14686 14516 -170
Branches 2334 2305 -29
==========================================
- Hits 14428 14260 -168
+ Misses 116 115 -1
+ Partials 142 141 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope we can maintain the usage of versionadded
and versionchanged
across the next major, it is really helpful
Co-authored-by: Jacob Coffee <jacob@z7x.org>
Quality Gate passedIssues Measures |
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3360 |
* refactor: removes deprecated OpenAPIController This PR removes all deprecated elements of OpenAPIConfig and the OpenAPIController, removes any obsolete tests and refactors tests that were parametrized to test both OpenAPIController and the router-based approach. * docs: What's new entry * Update docs/usage/openapi/ui_plugins.rst Co-authored-by: Jacob Coffee <jacob@z7x.org> * Update litestar/openapi/config.py * fix: remove whitespace * fix: import table formatting (i hope) --------- Co-authored-by: Jacob Coffee <jacob@z7x.org>
* refactor: removes deprecated OpenAPIController This PR removes all deprecated elements of OpenAPIConfig and the OpenAPIController, removes any obsolete tests and refactors tests that were parametrized to test both OpenAPIController and the router-based approach. * docs: What's new entry * Update docs/usage/openapi/ui_plugins.rst Co-authored-by: Jacob Coffee <jacob@z7x.org> * Update litestar/openapi/config.py * fix: remove whitespace * fix: import table formatting (i hope) --------- Co-authored-by: Jacob Coffee <jacob@z7x.org>
* refactor: removes deprecated OpenAPIController This PR removes all deprecated elements of OpenAPIConfig and the OpenAPIController, removes any obsolete tests and refactors tests that were parametrized to test both OpenAPIController and the router-based approach. * docs: What's new entry * Update docs/usage/openapi/ui_plugins.rst Co-authored-by: Jacob Coffee <jacob@z7x.org> * Update litestar/openapi/config.py * fix: remove whitespace * fix: import table formatting (i hope) --------- Co-authored-by: Jacob Coffee <jacob@z7x.org>
* refactor: removes deprecated OpenAPIController This PR removes all deprecated elements of OpenAPIConfig and the OpenAPIController, removes any obsolete tests and refactors tests that were parametrized to test both OpenAPIController and the router-based approach. * docs: What's new entry * Update docs/usage/openapi/ui_plugins.rst Co-authored-by: Jacob Coffee <jacob@z7x.org> * Update litestar/openapi/config.py * fix: remove whitespace * fix: import table formatting (i hope) --------- Co-authored-by: Jacob Coffee <jacob@z7x.org>
* refactor: removes deprecated OpenAPIController This PR removes all deprecated elements of OpenAPIConfig and the OpenAPIController, removes any obsolete tests and refactors tests that were parametrized to test both OpenAPIController and the router-based approach. * docs: What's new entry * Update docs/usage/openapi/ui_plugins.rst Co-authored-by: Jacob Coffee <jacob@z7x.org> * Update litestar/openapi/config.py * fix: remove whitespace * fix: import table formatting (i hope) --------- Co-authored-by: Jacob Coffee <jacob@z7x.org>
* refactor: removes deprecated OpenAPIController This PR removes all deprecated elements of OpenAPIConfig and the OpenAPIController, removes any obsolete tests and refactors tests that were parametrized to test both OpenAPIController and the router-based approach. * docs: What's new entry * Update docs/usage/openapi/ui_plugins.rst Co-authored-by: Jacob Coffee <jacob@z7x.org> * Update litestar/openapi/config.py * fix: remove whitespace * fix: import table formatting (i hope) --------- Co-authored-by: Jacob Coffee <jacob@z7x.org>
* refactor: removes deprecated OpenAPIController This PR removes all deprecated elements of OpenAPIConfig and the OpenAPIController, removes any obsolete tests and refactors tests that were parametrized to test both OpenAPIController and the router-based approach. * docs: What's new entry * Update docs/usage/openapi/ui_plugins.rst Co-authored-by: Jacob Coffee <jacob@z7x.org> * Update litestar/openapi/config.py * fix: remove whitespace * fix: import table formatting (i hope) --------- Co-authored-by: Jacob Coffee <jacob@z7x.org>
* refactor: removes deprecated OpenAPIController This PR removes all deprecated elements of OpenAPIConfig and the OpenAPIController, removes any obsolete tests and refactors tests that were parametrized to test both OpenAPIController and the router-based approach. * docs: What's new entry * Update docs/usage/openapi/ui_plugins.rst Co-authored-by: Jacob Coffee <jacob@z7x.org> * Update litestar/openapi/config.py * fix: remove whitespace * fix: import table formatting (i hope) --------- Co-authored-by: Jacob Coffee <jacob@z7x.org>
Description
This PR removes all deprecated elements of OpenAPIConfig and the OpenAPIController, removes any obsolete tests and refactors tests that were parametrized to test both OpenAPIController and the router-based approach.
Supersedes #3297 which superseded #3271
Closes