feat!: no implicit default for optional params #3361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterschutt
force-pushed
the
v3-no-implicit-optional-defaults-new-docs
branch
2 times, most recently
from
7197ec2
to
361c9d2
Compare
This PR changes behavior of parameters that are typed in a union with `None`. Prior behavior was to implicitly default their value to `None` if a value wasn't provided making an apparently non-optional parameter (i.e., no declared default) actually optional. Surprising behavior at best, dangerous at worst. New behavior is to throw a client error when a parameter without a default is not provided.
peterschutt
force-pushed
the
v3-no-implicit-optional-defaults-new-docs
branch
from
361c9d2
to
7f80ce5
Compare
github-actions
bot
added
area/docs
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3361 |
provinzkraut
approved these changes
Apr 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3.0 #3361 +/- ##
==========================================
+ Coverage 98.24% 98.28% +0.03%
==========================================
Files 321 323 +2
Lines 14687 14772 +85
Branches 2334 2345 +11
==========================================
+ Hits 14429 14518 +89
Misses 116 116
+ Partials 142 138 -4 ☔ View full report in Codecov by Sentry. |
provinzkraut
pushed a commit
that referenced
this pull request
Apr 13, 2024
This PR changes behavior of parameters that are typed in a union with `None`. Prior behavior was to implicitly default their value to `None` if a value wasn't provided making an apparently non-optional parameter (i.e., no declared default) actually optional. Surprising behavior at best, dangerous at worst. New behavior is to throw a client error when a parameter without a default is not provided.
provinzkraut
pushed a commit
that referenced
this pull request
Apr 20, 2024
This PR changes behavior of parameters that are typed in a union with `None`. Prior behavior was to implicitly default their value to `None` if a value wasn't provided making an apparently non-optional parameter (i.e., no declared default) actually optional. Surprising behavior at best, dangerous at worst. New behavior is to throw a client error when a parameter without a default is not provided.
provinzkraut
pushed a commit
that referenced
this pull request
Apr 21, 2024
This PR changes behavior of parameters that are typed in a union with `None`. Prior behavior was to implicitly default their value to `None` if a value wasn't provided making an apparently non-optional parameter (i.e., no declared default) actually optional. Surprising behavior at best, dangerous at worst. New behavior is to throw a client error when a parameter without a default is not provided.
provinzkraut
pushed a commit
that referenced
this pull request
Apr 27, 2024
This PR changes behavior of parameters that are typed in a union with `None`. Prior behavior was to implicitly default their value to `None` if a value wasn't provided making an apparently non-optional parameter (i.e., no declared default) actually optional. Surprising behavior at best, dangerous at worst. New behavior is to throw a client error when a parameter without a default is not provided.
provinzkraut
pushed a commit
that referenced
this pull request
Apr 27, 2024
This PR changes behavior of parameters that are typed in a union with `None`. Prior behavior was to implicitly default their value to `None` if a value wasn't provided making an apparently non-optional parameter (i.e., no declared default) actually optional. Surprising behavior at best, dangerous at worst. New behavior is to throw a client error when a parameter without a default is not provided.
provinzkraut
pushed a commit
that referenced
this pull request
Apr 28, 2024
This PR changes behavior of parameters that are typed in a union with `None`. Prior behavior was to implicitly default their value to `None` if a value wasn't provided making an apparently non-optional parameter (i.e., no declared default) actually optional. Surprising behavior at best, dangerous at worst. New behavior is to throw a client error when a parameter without a default is not provided.
provinzkraut
pushed a commit
that referenced
this pull request
May 25, 2024
This PR changes behavior of parameters that are typed in a union with `None`. Prior behavior was to implicitly default their value to `None` if a value wasn't provided making an apparently non-optional parameter (i.e., no declared default) actually optional. Surprising behavior at best, dangerous at worst. New behavior is to throw a client error when a parameter without a default is not provided.
provinzkraut
pushed a commit
that referenced
this pull request
May 26, 2024
This PR changes behavior of parameters that are typed in a union with `None`. Prior behavior was to implicitly default their value to `None` if a value wasn't provided making an apparently non-optional parameter (i.e., no declared default) actually optional. Surprising behavior at best, dangerous at worst. New behavior is to throw a client error when a parameter without a default is not provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
None. Prior behavior was to implicitly default their value toNoneif a value wasn't provided making an apparently non-optional parameter (i.e., no declared default) actually optional. Surprising behavior at best, dangerous at worst.New behavior is to throw a client error when a parameter without a default is not provided.
Closes
Closes #2518