fix: Path param consumed by dependency treated as unconsumed #3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/openapi
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3380 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 323 323
Lines 14778 14780 +2
Branches 2347 2347
=======================================
+ Hits 14524 14526 +2
Misses 116 116
Partials 138 138 ☔ View full report in Codecov by Sentry. |
Consider parameters defined in handler dependencies in order to determine if a path parameter has been consumed for openapi generation purposes. Fixes an issue where path parameters not consumed by the handler, but consumed by dependencies would cause an `ImproperlyConfiguredException`. Closes #3369
peterschutt
force-pushed
the
3369-path-param-unconsumed-in-dep
branch
from
fa8c298
to
35372c6
Compare
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3380 |
provinzkraut
approved these changes
Apr 12, 2024
4 tasks
peterschutt
added a commit
that referenced
this pull request
May 1, 2024
Consider parameters defined in handler dependencies in order to determine if a path parameter has been consumed for openapi generation purposes. Fixes an issue where path parameters not consumed by the handler, but consumed by dependencies would cause an `ImproperlyConfiguredException`. Closes #3369 (cherry picked from commit c3af6c6)
peterschutt
added a commit
that referenced
this pull request
May 2, 2024
Consider parameters defined in handler dependencies in order to determine if a path parameter has been consumed for openapi generation purposes. Fixes an issue where path parameters not consumed by the handler, but consumed by dependencies would cause an `ImproperlyConfiguredException`. Closes #3369 (cherry picked from commit c3af6c6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider parameters defined in handler dependencies in order to determine if a path parameter has been consumed for openapi generation purposes.
Fixes an issue where path parameters not consumed by the handler, but consumed by dependencies would cause an
ImproperlyConfiguredException.Closes #3369
Description
Closes