Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Remove deprecated app param of Response.to_asgi_response #3393

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

provinzkraut
Copy link
Member

Remove the deprecated app parameter of Response.to_asgi_response; Its usage has been replaced internally by request.app, and custom response classes can follow the same pattern.

@provinzkraut provinzkraut requested review from a team as code owners April 14, 2024 12:01
@github-actions github-actions bot added area/docs This PR involves changes to the documentation size: medium area/response pr/internal labels Apr 14, 2024
@provinzkraut provinzkraut merged commit 3ddb20e into v3.0 Apr 15, 2024
17 checks passed
@provinzkraut provinzkraut deleted the remove-response-asgi-param branch April 15, 2024 07:04
Copy link

sonarcloud bot commented Apr 15, 2024

Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3393

provinzkraut added a commit that referenced this pull request Apr 20, 2024
…e` (#3393)

* Remove 'app' parameter from `.to_asgi_response`
provinzkraut added a commit that referenced this pull request Apr 21, 2024
…e` (#3393)

* Remove 'app' parameter from `.to_asgi_response`
provinzkraut added a commit that referenced this pull request Apr 27, 2024
…e` (#3393)

* Remove 'app' parameter from `.to_asgi_response`
provinzkraut added a commit that referenced this pull request Apr 27, 2024
…e` (#3393)

* Remove 'app' parameter from `.to_asgi_response`
provinzkraut added a commit that referenced this pull request Apr 28, 2024
…e` (#3393)

* Remove 'app' parameter from `.to_asgi_response`
provinzkraut added a commit that referenced this pull request May 25, 2024
…e` (#3393)

* Remove 'app' parameter from `.to_asgi_response`
provinzkraut added a commit that referenced this pull request May 26, 2024
…e` (#3393)

* Remove 'app' parameter from `.to_asgi_response`
provinzkraut added a commit that referenced this pull request Jun 15, 2024
…e` (#3393)

* Remove 'app' parameter from `.to_asgi_response`
provinzkraut added a commit that referenced this pull request Jun 15, 2024
…e` (#3393)

* Remove 'app' parameter from `.to_asgi_response`
provinzkraut added a commit that referenced this pull request Jun 15, 2024
…e` (#3393)

* Remove 'app' parameter from `.to_asgi_response`
provinzkraut added a commit that referenced this pull request Jun 15, 2024
…deprecated params of internal `ExceptionHandlerMiddleware` (#3435)

* refactor!: Remove deprecated `app` param of `Response.to_asgi_response` (#3393)
* Remove 'app' parameter from `.to_asgi_response`
* Remove debug param
* Remove exception_handlers param
* Remove litestar.middleware.exceptions
provinzkraut added a commit that referenced this pull request Jun 16, 2024
…e` (#3393)

* Remove 'app' parameter from `.to_asgi_response`
provinzkraut added a commit that referenced this pull request Jun 16, 2024
…deprecated params of internal `ExceptionHandlerMiddleware` (#3435)

* refactor!: Remove deprecated `app` param of `Response.to_asgi_response` (#3393)
* Remove 'app' parameter from `.to_asgi_response`
* Remove debug param
* Remove exception_handlers param
* Remove litestar.middleware.exceptions
provinzkraut added a commit that referenced this pull request Jun 21, 2024
…e` (#3393)

* Remove 'app' parameter from `.to_asgi_response`
provinzkraut added a commit that referenced this pull request Jun 21, 2024
…deprecated params of internal `ExceptionHandlerMiddleware` (#3435)

* refactor!: Remove deprecated `app` param of `Response.to_asgi_response` (#3393)
* Remove 'app' parameter from `.to_asgi_response`
* Remove debug param
* Remove exception_handlers param
* Remove litestar.middleware.exceptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs This PR involves changes to the documentation area/response pr/internal size: medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants