fix: top-level import of optional package #3418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/plugins
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3418 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 324 324
Lines 14780 14780
Branches 2346 2346
=======================================
Hits 14526 14526
Misses 116 116
Partials 138 138 ☔ View full report in Codecov by Sentry. |
Fix import from `contrib.minijinja` without handling for case where dependency is not installed. Closes #3415
peterschutt
force-pushed
the
3415-flash-plugin-minijinja-import
branch
from
3be4a54
to
1102764
Compare
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3418 |
JacobCoffee
approved these changes
Apr 23, 2024
|
tested and working, thanks for the fix |
euri10
approved these changes
Apr 23, 2024
4 tasks
peterschutt
added a commit
that referenced
this pull request
May 1, 2024
(cherry picked from commit 63d338a)
peterschutt
added a commit
that referenced
this pull request
May 2, 2024
(cherry picked from commit 63d338a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix import from
contrib.minijinjawithout handling for case where dependency is not installed.Closes #3415
Description
Closes