fix: flash messages were not displayed on Redirect #3420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/plugins
euri10
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3420 +/- ##
=======================================
Coverage 98.29% 98.29%
=======================================
Files 328 328
Lines 14857 14864 +7
Branches 2356 2358 +2
=======================================
+ Hits 14603 14610 +7
Misses 116 116
Partials 138 138 ☔ View full report in Codecov by Sentry. |
Alc-Alc
reviewed
Apr 23, 2024
peterschutt
reviewed
Apr 23, 2024
There was a problem hiding this comment.
Is the flash config's reference to the session config necessary? I.e., can we check for a session middleware instead?
Also, I understand that current behavior is broken WRT to redirects, but should we try to make this change in a more backward compatible manner? I.e., if a session middleware is not found, fall back to the current implementation and include a deprecation warning that a session middleware will be required in a future version.
Improve search for session middleware by also looking for `MiddlewareWrapper`. It adds `SessionMiddleware` within itself if it is present.
…5_use_session_flash
peterschutt
approved these changes
Apr 28, 2024
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3420 |
peterschutt
pushed a commit
that referenced
this pull request
May 1, 2024
* fix: Redirect on flash messages were not displayed * Update litestar/plugins/flash.py Co-authored-by: Peter Schutt <peter.github@proton.me> * nit * checking for SessionMiddleware breaks tests ? * using context vars passes the tests which reveals tests are incorrect... * Revert "using context vars passes the tests which reveals tests are incorrect..." This reverts commit fd55270. * Revert "checking for SessionMiddleware breaks tests ?" This reverts commit bbf6236. * check config differently in app_init * Removed the session_config from the plugin config * Fix mypy weirdness: see explanation in https://mypy.readthedocs.io/en/stable/type_narrowing.html#issubclass * cant fix mypy * fix: use `is_class_and_subclass()` for mw check. * Added test for better coverage on middleware type switch * Add check for `session_auth.middleware.MiddlewareWrapper` Improve search for session middleware by also looking for `MiddlewareWrapper`. It adds `SessionMiddleware` within itself if it is present. --------- Co-authored-by: Peter Schutt <peter.github@proton.me> (cherry picked from commit c625ce7)
peterschutt
pushed a commit
that referenced
this pull request
May 2, 2024
* fix: Redirect on flash messages were not displayed * Update litestar/plugins/flash.py Co-authored-by: Peter Schutt <peter.github@proton.me> * nit * checking for SessionMiddleware breaks tests ? * using context vars passes the tests which reveals tests are incorrect... * Revert "using context vars passes the tests which reveals tests are incorrect..." This reverts commit fd55270. * Revert "checking for SessionMiddleware breaks tests ?" This reverts commit bbf6236. * check config differently in app_init * Removed the session_config from the plugin config * Fix mypy weirdness: see explanation in https://mypy.readthedocs.io/en/stable/type_narrowing.html#issubclass * cant fix mypy * fix: use `is_class_and_subclass()` for mw check. * Added test for better coverage on middleware type switch * Add check for `session_auth.middleware.MiddlewareWrapper` Improve search for session middleware by also looking for `MiddlewareWrapper`. It adds `SessionMiddleware` within itself if it is present. --------- Co-authored-by: Peter Schutt <peter.github@proton.me> (cherry picked from commit c625ce7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes