fix: logging to file with structlog #3425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterschutt
force-pushed
the
structlog-log-to-file
branch
from
537ab26
to
5316be2
Compare
JacobCoffee
changed the title
JacobCoffee
approved these changes
Apr 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3425 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 328 328
Lines 14851 14852 +1
Branches 2357 2357
=======================================
+ Hits 14595 14596 +1
Misses 117 117
Partials 139 139 ☔ View full report in Codecov by Sentry. |
peterschutt
force-pushed
the
structlog-log-to-file
branch
from
5cbefa1
to
a1d783e
Compare
peterschutt
commented
Apr 25, 2024
peterschutt
force-pushed
the
structlog-log-to-file
branch
from
a1d783e
to
d8d8b55
Compare
Fixes issue where adding a file handle to the config object would cause it to fail on call to `configure()`. - add e2e test for logging to file w/ structlog
peterschutt
force-pushed
the
structlog-log-to-file
branch
from
d8d8b55
to
0c920f0
Compare
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3425 |
peterschutt
added a commit
that referenced
this pull request
May 1, 2024
fix: structlog file logging Fixes issue where adding a file handle to the config object would cause it to fail on call to `configure()`. - add e2e test for logging to file w/ structlog (cherry picked from commit cc6d55b)
peterschutt
added a commit
that referenced
this pull request
May 2, 2024
fix: structlog file logging Fixes issue where adding a file handle to the config object would cause it to fail on call to `configure()`. - add e2e test for logging to file w/ structlog (cherry picked from commit cc6d55b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR fixes issue with converting
StructLoggingConfigto dict during call toconfigure()when the config object has a custom logger factory that references aTextIOobject, which cannot be pickled.Closes