fix: regular handler under mounted app #3430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/private-api
Alc-Alc
reviewed
Apr 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3430 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 328 328
Lines 14851 14851
Branches 2356 2357 +1
=======================================
Hits 14595 14595
Misses 117 117
Partials 139 139 ☔ View full report in Codecov by Sentry. |
Alc-Alc
approved these changes
Apr 26, 2024
Fix an issue where a regular handler under a mounted asgi app would prevent a request routing through the mounted application if the request path contained the path of the regular handler as a substring.
peterschutt
force-pushed
the
3429-fix-handler-under-mount-path
branch
from
53e9373
to
8480b16
Compare
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3430 |
4 tasks
peterschutt
added a commit
that referenced
this pull request
May 1, 2024
* fix: regular handler under mounted app Fix an issue where a regular handler under a mounted asgi app would prevent a request routing through the mounted application if the request path contained the path of the regular handler as a substring. * fix: remove duplicate asgi handler * fix: type-checkers (cherry picked from commit edf9400)
peterschutt
added a commit
that referenced
this pull request
May 2, 2024
* fix: regular handler under mounted app Fix an issue where a regular handler under a mounted asgi app would prevent a request routing through the mounted application if the request path contained the path of the regular handler as a substring. * fix: remove duplicate asgi handler * fix: type-checkers (cherry picked from commit edf9400)
|
Just spend some time debugging this issue and almost finished filling a bug report, but when trying to reference the line I found in sources, discovered it has already been fixed. Nice! And thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where a regular handler under a mounted asgi app would prevent a request from routing through the mounted application if the request path contained the path of the regular handler as a substring.
Closes #3429
Description
Closes