fix: clear session cookie if new session gt CHUNK_SIZE #3446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3446 +/- ##
==========================================
+ Coverage 98.27% 98.29% +0.01%
==========================================
Files 328 328
Lines 14852 14857 +5
Branches 2357 2356 -1
==========================================
+ Hits 14596 14603 +7
+ Misses 117 116 -1
+ Partials 139 138 -1 ☔ View full report in Codecov by Sentry. |
JacobCoffee
reviewed
Apr 28, 2024
JacobCoffee
approved these changes
Apr 28, 2024
peterschutt
force-pushed
the
3441-fix-clear-session
branch
from
fd3f9f0
to
0f478e0
Compare
peterschutt
commented
Apr 28, 2024
Alc-Alc
reviewed
Apr 28, 2024
provinzkraut
approved these changes
Apr 28, 2024
Fix an issue where the connection session cookie is not cleared if the response session is stored across multiple cookies. Closes #3441
Co-authored-by: Jacob Coffee <jacob@z7x.org>
peterschutt
force-pushed
the
3441-fix-clear-session
branch
from
db4059d
to
4aaa2cd
Compare
4 tasks
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3446 |
peterschutt
added a commit
that referenced
this pull request
May 1, 2024
* fix: clear session cookie if new session gt CHUNK_SIZE Fix an issue where the connection session cookie is not cleared if the response session is stored across multiple cookies. Closes #3441 * Update litestar/middleware/session/client_side.py Co-authored-by: Jacob Coffee <jacob@z7x.org> * refactor: use dataclass utils to iterate over Cookie fields --------- Co-authored-by: Jacob Coffee <jacob@z7x.org> (cherry picked from commit 0670551)
peterschutt
added a commit
that referenced
this pull request
May 2, 2024
* fix: clear session cookie if new session gt CHUNK_SIZE Fix an issue where the connection session cookie is not cleared if the response session is stored across multiple cookies. Closes #3441 * Update litestar/middleware/session/client_side.py Co-authored-by: Jacob Coffee <jacob@z7x.org> * refactor: use dataclass utils to iterate over Cookie fields --------- Co-authored-by: Jacob Coffee <jacob@z7x.org> (cherry picked from commit 0670551)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where the connection session cookie is not cleared if the response session is stored across multiple cookies.
Closes #3441
Description
Closes