fix(pydantic v1): field not optional if default value #3476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterschutt
force-pushed
the
3471-pydantic-v1-field-default
branch
from
5a06b57
to
31e8bb9
Compare
Fix issue where a pydantic v1 field annotation is wrapped with `Optional` if it is marked not required, but has a default value. Closes #3471
peterschutt
force-pushed
the
3471-pydantic-v1-field-default
branch
from
31e8bb9
to
ea193e5
Compare
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3476 |
cofin
approved these changes
May 7, 2024
JacobCoffee
approved these changes
May 7, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where a pydantic v1 field annotation is wrapped with
Optionalif it is marked not required, but has a default value.Closes #3471
Description
Closes