fix(warnings): Do not warn for default handlers #3569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alc-Alc
requested review from
JacobCoffee,
provinzkraut and
a team
as code owners
github-actions
bot
added
area/docs
|
Added a test that fails in current main, but not on this branch |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3569 +/- ##
=======================================
Coverage 98.27% 98.28%
=======================================
Files 328 328
Lines 14824 14835 +11
Branches 2362 2362
=======================================
+ Hits 14569 14580 +11
Misses 116 116
Partials 139 139 ☔ View full report in Codecov by Sentry. |
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3569 |
provinzkraut
approved these changes
Jun 15, 2024
provinzkraut
deleted the
3552-bug-normal-usage-of-route-handler-decorators-causes-deprecation-warnings
branch
4 tasks
provinzkraut
pushed a commit
that referenced
this pull request
Jun 21, 2024
* fix(warnings): Do not warn for default handlers * test: add test to check (lack of) warnings --------- Co-authored-by: Alc-Alc <alc@localhost> (cherry picked from commit 064c8fe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
__init_subclass__es for the default handlers.Closes
Closes #3552