Issue #289- eager eval of is async #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goldziher
changed the title
Goldziher
force-pushed
the
issue-289-eager-eval-of-is-async
branch
from
15b2f46
to
5d18017
Compare
cofin
approved these changes
Aug 20, 2022
peterschutt
reviewed
Aug 20, 2022
peterschutt
reviewed
Aug 21, 2022
- makes `utils.predicates.is_async_callable()` a type guard - makes `AsyncCallable` generic on `P` and `T`.
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #289 by adding an
AsyncCallablewrapper. I then applied if everywhere we can pre-compute this.Note- i removed the
LifeCycleHookwrapper because it was redundant with this addition.