Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access custom response in session middleware #491

Merged
merged 6 commits into from
Sep 17, 2022
Merged

Access custom response in session middleware #491

merged 6 commits into from
Sep 17, 2022

Conversation

Goldziher
Copy link
Contributor

PR Checklist

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you got 100% test coverage on new code?
  • Have you updated the prose documentation?
  • Have you updated the reference documentation?

This PR resolves issue #490

Goldziher
Goldziher commented Sep 17, 2022
View reviewed changes
starlite/connection.py Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Goldziher Goldziher merged commit 51a8d85 into main Sep 17, 2022
@Goldziher Goldziher deleted the issue-490-session-middleware-serializer branch September 17, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cofin cofin cofin approved these changes

@peterschutt peterschutt Awaiting requested review from peterschutt

@infohash infohash Awaiting requested review from infohash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Goldziher @cofin