Create RequestFactory to eventually replace create_test_request

[seladb]

Addresses issue #459

To make it easier to review, this PR only adds RequestFactory and doesn't remove create_test_request. Once this is merged I'll open another PR to replace and remove create_test_request

The RequestFactory is heavily inspired by Django's RequestFactory

PR Checklist

• Have you followed the guidelines in CONTRIBUTING.md?
• Have you got 100% test coverage on new code?
• Have you updated the prose documentation?
• Have you updated the reference documentation?

[Goldziher]

This looks good!

Please add doc strings to all methods, even private ones, and add a doc string to the __init__ method which gives an explanation on the class etc. See for example the doc string in starlite.datastructures.State.__init__.

[seladb]

This looks good!

Please add doc strings to all methods, even private ones, and add a doc string to the __init__ method which gives an explanation on the class etc. See for example the doc string in starlite.datastructures.State.__init__.

Thanks @Goldziher , added here: f68b46a

[seladb]

@Goldziher is it safe to merge?

[peterschutt]

Should add docs: https://starlite-api.github.io/starlite/usage/14-testing/#creating-a-test-request and also add the class and public members to reference docs: https://github.com/starlite-api/starlite/blob/main/docs/reference/testing.md

[seladb]

Should add docs: https://starlite-api.github.io/starlite/usage/14-testing/#creating-a-test-request and also add the class and public members to reference docs: https://github.com/starlite-api/starlite/blob/main/docs/reference/testing.md

@peterschutt I think I'll do it as part of the next PR which removes create_test_request otherwise it might be confusing to have 2 ways to create test request, what do you think? 🤔

[Goldziher]

@Goldziher is it safe to merge?

merge when ready

[seladb]

Should add docs: https://starlite-api.github.io/starlite/usage/14-testing/#creating-a-test-request and also add the class and public members to reference docs: https://github.com/starlite-api/starlite/blob/main/docs/reference/testing.md

@peterschutt I think I'll do it as part of the next PR which removes create_test_request otherwise it might be confusing to have 2 ways to create test request, what do you think? 🤔

When thinking about it again, since create_test_request is exposed to users, can we actually remove it? If we do and someone uses it, it'd be a breaking change for them.
What do you think we should do?

• Keep both create_test_request and the new RequestFactory and mark create_test_request as deprecated? (if so, what's the best way to mark something as deprecated?)
• Or just remove create_test_request once this PR is merged?

This decision also affects the documentation we want to add about the new RequestFactory

cc @Goldziher @peterschutt @infohash

[peterschutt]

When thinking about it again, since create_test_request is exposed to users, can we actually remove it? If we do and someone uses it, it'd be a breaking change for them.
What do you think we should do?

It should be deprecated if we are to remove it. Can you re-implement it so that keeps the same interface but uses RequestFactory underneath?

[seladb]

When thinking about it again, since create_test_request is exposed to users, can we actually remove it? If we do and someone uses it, it'd be a breaking change for them.
What do you think we should do?

It should be deprecated if we are to remove it. Can you re-implement it so that keeps the same interface but uses RequestFactory underneath?

Yes sure, that's a good idea. So I'll update the documentation in this PR and mention create_test_request as deprecated. In a following PR I'll remove all of our internal usages of create_test_request and re-implement this method to use RequestFactory. @peterschutt does that work?

[peterschutt]

Yes sure, that's a good idea. So I'll update the documentation in this PR and mention create_test_request as deprecated. In a following PR I'll remove all of our internal usages of create_test_request and re-implement this method to use RequestFactory. @peterschutt does that work?

Sounds reasonable to me. If it isn't hard to implement it using RequestFactory then I wouldn't even worry about the deprecation - saves people having to rewrite tests if we can keep the interface.

[seladb]

Yes sure, that's a good idea. So I'll update the documentation in this PR and mention create_test_request as deprecated. In a following PR I'll remove all of our internal usages of create_test_request and re-implement this method to use RequestFactory. @peterschutt does that work?

Sounds reasonable to me. If it isn't hard to implement it using RequestFactory then I wouldn't even worry about the deprecation - saves people having to rewrite tests if we can keep the interface.

ok sure, I'll do it in a separate PR