Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor create_test_request to use RequestFactory #510

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Refactor create_test_request to use RequestFactory #510

merged 2 commits into from
Sep 23, 2022

Conversation

seladb
Copy link
Contributor

@seladb seladb commented Sep 23, 2022

  • Refactor create_test_request to use RequestFactory
  • Add scheme to RequestFactory (which was missing in the previous PR)
  • Change all internal uses of create_test_request to use RequestFactory

PR Checklist

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you got 100% test coverage on new code?
  • Have you updated the prose documentation?
  • Have you updated the reference documentation?

@seladb
- Refactor create_test_request to use RequestFactory
909232c 
- Add `scheme` to `RequestFactory` (was missing in the previous PR)
- Change all internal uses of `create_test_request` to use `RequestFactory`
@seladb
Merge from main
0b102d1
seladb
seladb commented Sep 23, 2022
View reviewed changes
tests/test_testing.py Show resolved Hide resolved
tests/test_testing.py Show resolved Hide resolved
starlite/testing.py Show resolved Hide resolved
starlite/testing.py Show resolved Hide resolved
@seladb seladb marked this pull request as ready for review September 23, 2022 07:39
@peterschutt peterschutt merged commit 6ce6ce5 into litestar-org:main Sep 23, 2022
Alex-CodeLab pushed a commit to Alex-CodeLab/starlite that referenced this pull request Sep 30, 2022
@seladb
Refactor create_test_request to use RequestFactory (litestar-org#510
a27969e 
)

- Refactor `create_test_request` to use `RequestFactory`
- Add `scheme` to `RequestFactory` (was missing in the previous PR)
- Change all internal uses of `create_test_request` to use `RequestFactory`
@seladb seladb deleted the refactor-create-test-request branch October 12, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterschutt peterschutt peterschutt approved these changes

@Goldziher Goldziher Awaiting requested review from Goldziher

@infohash infohash Awaiting requested review from infohash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seladb @peterschutt