Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add sqlalchemy factory #272

Closed
wants to merge 2 commits into from
Closed

feat: Add sqlalchemy factory #272

wants to merge 2 commits into from

Conversation

Goldziher
Copy link
Contributor

This PR adds an SQLAlchemy base factory. It is currently WIP. Anyone interested in taking over is welcome to continue work on this PR and target it with a pull request.

@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mdczaplicki
Copy link
Contributor

I'll give it a go

@Goldziher
Copy link
Contributor Author

@litestar-org/members or @litestar-org/maintainers any of you want to take this over? Issue is pending for a while and it would be a good addition.

@Goldziher Goldziher changed the title Add sqlalchemy factory feat: Add sqlalchemy factory Aug 30, 2023
* feat: Add SQLAlchemyFactory table column parsing

* docs: Add SQLAlchemy reference

* docs: amend link

* doc: amend link

* Revert type updates

* feat: add SQLAlchemy relationship configuration

* feat: improve mapping for SQLAlchemy ARRAY

* feat: SQLAlchemy test hints for 3.8

* feat: SQLAlchemy test hints for 3.8

* feat: SQLAlchemy test hints for 3.8

* feat: SQLAlchemy factory hints for 3.8

* feat: add extra attributes for SQLAlchemyFactory

* feat: resolve SQLAlchemyFactory type issues

* feat: fix rebase errors
@Goldziher
Copy link
Contributor Author

@guacs please take over this PR from here

@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@guacs
Copy link
Member

guacs commented Aug 30, 2023

@guacs please take over this PR from here

Yupp, I just haven't had the time to really read through the code completely yet. I'll go through this by this weekend.

@guacs guacs removed their assignment Sep 15, 2023
@guacs
Copy link
Member

guacs commented Sep 15, 2023

@adhtruong Feel free to work on this :)

@guacs
Copy link
Member

guacs commented Sep 18, 2023

Completed in #369.

@guacs guacs closed this Sep 18, 2023
@guacs guacs deleted the sqlalchemy-factory branch September 18, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants