New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly type hint create_factory #360

Merged

guacs merged 2 commits into main from create-factory-typing

Sep 16, 2023

Member

guacs commented Sep 14, 2023

Pull Request Checklist

New code has 100% test coverage
(If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
(If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
Pre-Commit Checks were ran and passed
Tests were ran and passed

Description

This PR makes the type hints for BaseFactory.create_factory generic to allow type checkers to properly infer the type of the created factory.

Close Issue(s)

Fixes Enhancement: Add proper typings to create_factory function #358


          fix: properly type hint create_factory

1701df3

guacs requested review from a team as code owners

September 14, 2023 14:38

sobolevn reviewed

View reviewed changes

polyfactory/factories/base.py Show resolved Hide resolved


          docs: ignore 'F' generic type when building docs

43a52c9

guacs requested review from JacobCoffee and provinzkraut as code owners

September 15, 2023 14:37

sonarcloud bot commented Sep 15, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

JacobCoffee approved these changes

View reviewed changes

guacs merged commit 2a20513 into main

17 checks passed

guacs deleted the create-factory-typing branch

September 16, 2023 11:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment