fix: Dataclass field type not used correctly

[anthonyjgraff]

Pull Request Checklist

• New code has 100% test coverage
• (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
• (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
• Pre-Commit Checks were ran and passed
• Tests were ran and passed

Description

• Get dataclass type information from field.type instead of using typing.get_type_hints

Close Issue(s)

• Fixes Bug: SQLAlchemy Mapped field type not used correctly #347

[anthonyjgraff]

Any idea why this test would fail? I can't recreate the failure locally...

Maybe we got unlucky and added the same key to the dictionary twice?

[guacs]

Any idea why this test would fail? I can't recreate the failure locally...

Maybe we got unlucky and added the same key to the dictionary twice?

Ohhh this could very well be it. There's an issue #362, that's open regarding this. This has been happening for a while and for some reason I never realized that it could just be adding the same key twice.

[guacs]

@anthonyjgraff could you rebase from main? I've skipped that test for now.

[guacs]

Could you skip the sqlalchemy tests if the sqlalchemy is v1 since MappedAsDataclass is only available from v2 onwards?

[guacs]

I just have that one doubt. Everything else looks great!

[guacs]

@all-contributors add @anthonyjgraff for code

[allcontributors]

@guacs

I've put up a pull request to add @anthonyjgraff! 🎉

[guacs]

@anthonyjgraff could you rebase from main. I think you might have to undo almost all of what I mentioned regarding the setting of sqlalchemy dependency in pyproject.toml now that #369 is completed. Sorry about that.