Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update fixture size handling #373

Merged
merged 1 commit into from
Sep 18, 2023
Merged

fix: update fixture size handling #373

merged 1 commit into from
Sep 18, 2023

Conversation

adhtruong
Copy link
Collaborator

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
  • Pre-Commit Checks were ran and passed
  • Tests were ran and passed

Description

  • Fix fixture size handling for 0

Close Issue(s)

@adhtruong adhtruong requested review from a team as code owners September 18, 2023 09:09
guacs
guacs approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@guacs guacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@guacs guacs merged commit 8e41372 into litestar-org:main Sep 18, 2023
15 checks passed
@adhtruong adhtruong deleted the update-fixture-size-handling branch September 19, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guacs guacs guacs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: When setting size=0, 1 instance is created and not put in a list
2 participants
@adhtruong @guacs