Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix alternative version installation #389

Merged
merged 5 commits into from
Sep 28, 2023

Conversation

adhtruong
Copy link
Collaborator

@adhtruong adhtruong commented Sep 26, 2023

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
  • Pre-Commit Checks were ran and passed
  • Tests were ran and passed

Description

  • Ensure correct version is installed
  • Add extra cache file to ensure distinct caches
  • Change to pdm sync to ensure packages aren't updated with install.

Close Issue(s)

@adhtruong adhtruong changed the title infra: fix alternative version installation fix: fix alternative version installation Sep 26, 2023
@guacs
Copy link
Member

guacs commented Sep 27, 2023

@adhtruong, if you want a faster feedback looping when testing things, you can try taking a look at act. Or you can just keep on pushing to this branch to trigger the workflows. Either way is fine. Completely up to you.

@adhtruong
Copy link
Collaborator Author

@adhtruong, if you want a faster feedback looping when testing things, you can try taking a look at act. Or you can just keep on pushing to this branch to trigger the workflows. Either way is fine. Completely up to you.

Interesting. Will look into this and set up!

@adhtruong adhtruong marked this pull request as ready for review September 27, 2023 17:37
@adhtruong adhtruong requested review from a team as code owners September 27, 2023 17:37
@github-actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/polyfactory-docs-preview/389

@guacs guacs merged commit 8ef78b8 into litestar-org:main Sep 28, 2023
20 checks passed
@adhtruong adhtruong deleted the fix-alt-version-installation branch October 18, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Pipeline does not install alternative versions correctly
3 participants