Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refactor the msgspec factory to use the fields API #409

Merged
merged 3 commits into from
Oct 14, 2023
Merged

refactor: refactor the msgspec factory to use the fields API #409

merged 3 commits into from
Oct 14, 2023

Conversation

guacs
Copy link
Member

@guacs guacs commented Oct 14, 2023 •
edited
Loading

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
  • Pre-Commit Checks were ran and passed
  • Tests were ran and passed

Description

  • use the fields API as suggested here
  • don't repeatedly call get_type_hints

@guacs guacs requested review from a team as code owners October 14, 2023 18:23
cofin
cofin approved these changes Oct 14, 2023
View reviewed changes
Copy link
Member

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guacs guacs enabled auto-merge (squash) October 14, 2023 18:37
@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@guacs guacs merged commit f555636 into main Oct 14, 2023
21 checks passed
@guacs guacs deleted the msgspec-factory-refactor branch October 14, 2023 18:42
@github-actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/polyfactory-docs-preview/409

sam-or pushed a commit to sam-or/polyfactory that referenced this pull request Oct 16, 2023
@guacs @sam-or
refactor: refactor the msgspec factory to use the fields API (litesta…
8a3ac1f 
…r-org#409)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cofin cofin cofin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guacs @cofin