feat: deprecate FieldMeta collection params

[adhtruong]

Pull Request Checklist

• New code has 100% test coverage
• (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
• (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
• Pre-Commit Checks were ran and passed
• Tests were ran and passed

Description

• Vendor in https://github.com/litestar-org/litestar/blob/main/litestar/utils/deprecation.py#L71, adjust and add parameter util.
• Deprecate collection params for FieldMeta
• Update PydanticFieldMeta implementation. This harmonises usage with other FieldMeta and think extending is implicitly ignored right now

Close Issue(s)

• Closes Enhancement: Deprecate collection params in FieldMeta.from_type #415

[guacs]

Thanks for the quick work! It looks great :)

[adhtruong]

Something to note that this doesn't work for positional arg usage. This feels like reasonable limitation but happy to move warning usage into the methods themselves to be able to detect this.

[guacs]

Something to note that this doesn't work for positional arg usage. This feels like reasonable limitation but happy to move warning usage into the methods themselves to be able to detect this.

By this do you mean a check to see whether the value is set to a non-default value in those methods and then if so, raise the deprecation warning?

[adhtruong]

Something to note that this doesn't work for positional arg usage. This feels like reasonable limitation but happy to move warning usage into the methods themselves to be able to detect this.

By this do you mean a check to see whether the value is set to a non-default value in those methods and then if so, raise the deprecation warning?

Exactly. Theoretically this could be done by a decorator but seems overly complex for this use case so in body would be my preference if want to flag positional usage.

[guacs]

Something to note that this doesn't work for positional arg usage. This feels like reasonable limitation but happy to move warning usage into the methods themselves to be able to detect this.

By this do you mean a check to see whether the value is set to a non-default value in those methods and then if so, raise the deprecation warning?

Exactly. Theoretically this could be done by a decorator but seems overly complex for this use case so in body would be my preference if want to flag positional usage.

Yeah, I agree, a decorator would be too much. I think this a good idea and I remember this being done in litestar as well though I don't remember exactly where.

[adhtruong]

Got it. I'll update so positional usage is flagged too

[guacs]

@adhtruong I just had that one doubt regarding the naming. Everything else looks great!

[github-actions]

Documentation preview will be available shortly at https://litestar-org.github.io/polyfactory-docs-preview/417