Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Reorder docs. Add docs on Factories as fields #418

Merged
merged 1 commit into from
Oct 20, 2023
Merged

docs: Reorder docs. Add docs on Factories as fields #418

merged 1 commit into from
Oct 20, 2023

Conversation

adhtruong
Copy link
Collaborator

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
  • Pre-Commit Checks were ran and passed
  • Tests were ran and passed

Description

Close Issue(s)

@adhtruong adhtruong requested review from a team as code owners October 20, 2023 08:06
@github-actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/polyfactory-docs-preview/418

guacs
guacs approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@guacs guacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I didn't realize we could just set the factories and that things would work due to the logic in BaseFactory._handle_factory_field.

@guacs guacs merged commit 11f234c into litestar-org:main Oct 20, 2023
19 checks passed
@adhtruong adhtruong deleted the docs-reorder branch October 21, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guacs guacs guacs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adhtruong @guacs