Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle Required and NonRequired annotations #422

Merged
merged 4 commits into from
Oct 21, 2023
Merged

fix: handle Required and NonRequired annotations #422

merged 4 commits into from
Oct 21, 2023

Conversation

guacs
Copy link
Member

@guacs guacs commented Oct 21, 2023

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
  • Pre-Commit Checks were ran and passed
  • Tests were ran and passed

Description

  • properly handle Required and NonRequired annotations

Close Issue(s)

@guacs guacs requested review from a team as code owners October 21, 2023 03:13
peterschutt
peterschutt approved these changes Oct 21, 2023
View reviewed changes
tests/test_typeddict_factory.py Show resolved Hide resolved
tests/constraints/test_int_constraints.py Show resolved Hide resolved
@guacs guacs enabled auto-merge (squash) October 21, 2023 09:47
@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@guacs guacs merged commit caaee0f into main Oct 21, 2023
21 checks passed
@guacs guacs deleted the typeddict-required-not-required branch October 21, 2023 09:52
@github-actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/polyfactory-docs-preview/422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterschutt peterschutt peterschutt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Required fields in TypedDicts throw exceptions
2 participants
@guacs @peterschutt