New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle cases where 'init=False' for dataclasses and attrs models #433

Merged

guacs merged 2 commits into main from dataclasses-init

Nov 1, 2023

Member

guacs commented Nov 1, 2023

Pull Request Checklist

New code has 100% test coverage
(If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
(If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
Pre-Commit Checks were ran and passed
Tests were ran and passed

Description

This PR checks if the init value is set to False for dataclasses and attrs models before creating the field metas

Close Issue(s)

Fixes Bug: init=False not respected for dataclasses #416

guacs added 2 commits

November 1, 2023 18:22


          fix: respect 'init' in dataclasses

50f37e3


          fix: respect 'init' in attrs models

d6f17ea

guacs requested review from a team as code owners

November 1, 2023 12:58

sonarcloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

github-actions bot commented Nov 1, 2023

Documentation preview will be available shortly at https://litestar-org.github.io/polyfactory-docs-preview/433

guacs enabled auto-merge (squash)

November 1, 2023 13:12

peterschutt approved these changes

View reviewed changes

guacs merged commit 70d49fd into main

21 checks passed

guacs deleted the dataclasses-init branch

November 1, 2023 13:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment