New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Optional `model` type (Sourcery refactored) #453

Closed

sourcery-ai wants to merge 4 commits into main from sourcery/pull-452

sourcery-ai bot commented Dec 8, 2023

Pull Request #452 refactored by Sourcery.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.

To incorporate these changes, you can either:

Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Incorporate changes via command line
```
git fetch https://github.com/litestar-org/polyfactory pull/452/head
git merge --ff-only FETCH_HEAD
git push
```

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Help us improve this pull request!

Mityuha and others added 4 commits

December 6, 2023 20:35


          add optional model field tests

8f49d33


          implement infer_model_type classmethod

c6f544a


          base model does not support generics within 1.10

4f660c4


          'Refactored by Sourcery'

21b3a5c

sourcery-ai bot added the build-ignore label

sourcery-ai bot requested review from a team as code owners

December 8, 2023 14:13

sonarcloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

github-actions bot commented Dec 8, 2023

Documentation preview will be available shortly at https://litestar-org.github.io/polyfactory-docs-preview/453

Member

guacs commented Dec 9, 2023

@Mityuha if you think there's something relevant in this refactor, please do add it to your PR.

guacs closed this

Contributor

Mityuha commented Dec 9, 2023

@guacs Thank you. Didn't know about sourcery refactoring. We already discussed an inline IF with Jacob Coffee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment