Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add min version to typing-extensions #471

Merged
merged 3 commits into from
Jan 13, 2024
Merged

Conversation

hsorsky
Copy link
Contributor

@hsorsky hsorsky commented Jan 2, 2024

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
  • Pre-Commit Checks were ran and passed
  • Tests were ran and passed

Description

Add minimum typing-extensions version in dependencies.

Close Issue(s)

Closes #470

@hsorsky hsorsky requested review from a team as code owners January 2, 2024 19:58
@guacs guacs changed the title add min version to typing-extensions fix: add min version to typing-extensions Jan 3, 2024
@guacs
Copy link
Member

guacs commented Jan 3, 2024

@hsorsky thanks for pointing this out! Could you run pdm lock so that the lockfile gets updated as well? Also, please be sure to use the same pdm version as specified in .pre-commit-config.yaml or else the hook to check the lockfile will fail since pdm will return a non-zero exit code when it detects that the lockfile was created with a different pdm version.

Or if you want, I could do this for you. Just let me know!

@hsorsky
Copy link
Contributor Author

hsorsky commented Jan 8, 2024

@guacs if you could, that'd be great. I'm not a pdm user, so avoiding having to install it would be ideal

@guacs guacs enabled auto-merge (squash) January 11, 2024 02:51
@guacs
Copy link
Member

guacs commented Jan 11, 2024

@all-contributors add @hsorsky for infra

Copy link
Contributor

@guacs

I've put up a pull request to add @hsorsky! 🎉

@guacs guacs merged commit fb4e50a into litestar-org:main Jan 13, 2024
19 checks passed
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/polyfactory-docs-preview/471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Incomplete Dependency Specification
2 participants