fix: set as default type for factory only if model is defined #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In base factories, the '__model__' will not be defined and so it an 'AttributeError' will be raised when trying to access 'cls.__model__'. So we simply ensure that '__model__' defined before trying to access it.
guacs
force-pushed
the
set-as-default-factory-for-type
branch
from
4760e6d
to
7c7cc11
Compare
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/polyfactory-docs-preview/479 |
provinzkraut
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
__set_as_default_factory_for_type__is set totTrue, we try to access the__model__in order to map the type to the factory. However, in base factories, the 'model' will not be defined and so it an 'AttributeError' will be raised when trying to access 'cls.model'. So, we simply ensure that 'model' defined before trying to access it.Close Issue(s)
__set_as_default_factory_for_type__toTrueon base factory fails #476.