Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support type alias #487

Merged
merged 4 commits into from
Jan 19, 2024
Merged

feat: support type alias #487

merged 4 commits into from
Jan 19, 2024

Conversation

adhtruong
Copy link
Collaborator

@adhtruong adhtruong commented Jan 17, 2024 •
edited
Loading

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
  • Pre-Commit Checks were ran and passed
  • Tests were ran and passed

Description

  • Add Python 3.12 to python and update targets.
  • Support type soft keyword.

Close Issue(s)

@adhtruong adhtruong force-pushed the support-type-alias branch 2 times, most recently from 9589176 to 5ef0314 Compare January 17, 2024 17:11
@adhtruong adhtruong force-pushed the support-type-alias branch 3 times, most recently from bb2b60d to b4fed54 Compare January 17, 2024 17:34
@adhtruong adhtruong marked this pull request as ready for review January 17, 2024 17:41
@adhtruong adhtruong requested review from a team as code owners January 17, 2024 17:41
guacs
guacs approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@guacs guacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adhtruong!

@guacs guacs enabled auto-merge (squash) January 19, 2024 02:57
@guacs guacs merged commit 94ad561 into litestar-org:main Jan 19, 2024
21 checks passed
@github-actions GitHub Actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/polyfactory-docs-preview/487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guacs guacs guacs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Support for Python 3.12 type keyword
2 participants
@adhtruong @guacs