Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prefer sqlalchemy.type.impl if it exists #502

Merged
merged 3 commits into from
Feb 17, 2024
Merged

fix: prefer sqlalchemy.type.impl if it exists #502

merged 3 commits into from
Feb 17, 2024

Conversation

cofin
Copy link
Member

@cofin cofin commented Feb 17, 2024

This PR checks for the impl property before default to type.python_type.

This is the documented way to use the sqlalchemy.types.TypeDecorator

@cofin cofin requested review from a team as code owners February 17, 2024 19:35
@cofin cofin linked an issue Feb 17, 2024 that may be closed by this pull request
@cofin cofin enabled auto-merge (squash) February 17, 2024 19:37
Copy link

sonarcloud bot commented Feb 17, 2024

@cofin cofin merged commit c4e3d91 into main Feb 17, 2024
22 checks passed
@cofin cofin deleted the sa-impl-type branch February 17, 2024 19:55
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/polyfactory-docs-preview/502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: support column.type impl attribute
2 participants