Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use github.com/google/uuid instead of github.com/satori/go.uuid #13

Merged
merged 1 commit into from
Feb 19, 2018

Conversation

lithammer
Copy link
Owner

@lithammer lithammer commented Feb 14, 2018

Given the recent issues with github.com/satori/go.uuid (satori/go.uuid#66), which are still partly unresolved, e.g. its master isn't compatible with us (see #7, #8, #9, 10, #11 and #12).

Even though github.com/google/uuid is only at v0.1 and clearly states this:

This package is currently in development and the API may not be stable.

The API will become stable with v1.

I suspect it's a better longterm investment. And speed wise they seem pretty identical:

google/uuid

BenchmarkUUID-4       	  200000	   7967 ns/op	    5768 B/op	   157 allocs/op
BenchmarkEncoding-4   	  200000	   6635 ns/op	    5776 B/op	   157 allocs/op
BenchmarkDecoding-4   	 1000000	   2126 ns/op	    1228 B/op	    38 allocs/op

satori/go.uuid

BenchmarkUUID-4       	  200000	   8188 ns/op	    5768 B/op	   157 allocs/op
BenchmarkEncoding-4   	  200000	   6726 ns/op	    5776 B/op	   157 allocs/op
BenchmarkDecoding-4   	 1000000	   2156 ns/op	    1228 B/op	    38 allocs/op

@lithammer lithammer self-assigned this Feb 14, 2018
@lithammer
Copy link
Owner Author

@dcarbone @semafor @zanjs you might be interested in this.

Given the recent issues with github.com/satori/go.uuid
(satori/go.uuid#66), which are still partly
unresolved, e.g. its master isn't compatible with us
(see #7, #8, #9, 10, #11 and #12).

Even though github.com/google/uuid is only at v0.1 and clearly states
this:

>This package is currently in development and the API may not be stable.
>
>The API will become stable with v1.

I suspect it's a better longterm investment.
@zanjs
Copy link

zanjs commented Feb 14, 2018

@Renstrom Nice!

@dcarbone
Copy link
Contributor

This would be a nice move, i think :)

@lithammer lithammer merged commit 4faf8f3 into master Feb 19, 2018
@lithammer lithammer deleted the use-github-google-uuid branch February 19, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants