Get max_tries/max_time values for every call fixes #160 #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgreen-litl
requested changes
Jun 7, 2022
There was a problem hiding this comment.
Good find. I didn't intend to change the behavior. This is the commit that did it b1cbbb5
Your fix looks good but one comment inline.
jvrsantacruz
force-pushed
the
eval_max_tries_on_every_call
branch
from
960868a
to
732eaa3
Compare
|
@jvrsantacruz thank you for this! merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes backoff to dynamically get the
max_triesandmax_timevalues for every new call and always try to evaluate.Avoid caching the first obtained value for all executions.
See #160