Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Started using timeit for measuring elapsed time #185

Closed
wants to merge 1 commit into from
Closed

Started using timeit for measuring elapsed time #185

wants to merge 1 commit into from

Conversation

VitalyAssurance
Copy link

@VitalyAssurance VitalyAssurance commented Dec 19, 2022

There is some evidence based on Datadog traces that backoff library does not calculate elapsed time correctly. For example, there are occurrences where extra retries are made even though the elapsed time exceeds specified max_time parameter for backoff.on_exception decorator. I suspect the problem is due to system clock being adjusted for time drift, or a similar issue.

I propose to use timeit instead of datetime.datetime.now() for measuring elapsed time.

@VitalyAssurance VitalyAssurance closed this by deleting the head repository Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant