Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Added support to update the experiment Statuses for Aborted Experiments #160

Merged
merged 2 commits into from
Mar 27, 2020

Conversation

rahulchheda
Copy link
Member

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Checklist:

  • Fixes #
  • Labelled this PR & related issue with documentation tag
  • PR messages has document related information
  • Labelled this PR & related issue with breaking-changes tag
  • PR messages has breaking changes related information
  • Labelled this PR & related issue with requires-upgrade tag
  • PR messages has upgrade related information
  • Commit has unit tests
  • Commit has integration tests

@rahulchheda rahulchheda changed the title Aborted exp (feat) Added support to update the experiment Statuses for Aborted Experiments Mar 9, 2020
Copy link
Member

@ksatchit ksatchit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP

@rahulchheda rahulchheda force-pushed the abortedExp branch 2 times, most recently from d93f21e to 0bd5deb Compare March 12, 2020 12:51
@rahulchheda rahulchheda self-assigned this Mar 26, 2020
…periments

Signed-off-by: Rahul M Chheda <rahul.chheda@mayadata.io>
@rahulchheda
Copy link
Member Author

rahulchheda commented Mar 27, 2020

Sample Aborted ChaosEngine:

rahul_chheda_mayadata_io@rahulchheda:~$ kubectl describe chaosengine engine -n litmus
Name:         engine
Namespace:    litmus
Labels:       <none>
Annotations:  kubectl.kubernetes.io/last-applied-configuration:
                {"apiVersion":"litmuschaos.io/v1alpha1","kind":"ChaosEngine","metadata":{"annotations":{},"name":"engine","namespace":"litmus"},"spec":{"a...
API Version:  litmuschaos.io/v1alpha1
Kind:         ChaosEngine
Metadata:
  Creation Timestamp:  2020-03-27T10:57:00Z
  Generation:          12
  Resource Version:    20233008
  Self Link:           /apis/litmuschaos.io/v1alpha1/namespaces/litmus/chaosengines/engine
  UID:                 af4061f9-7019-11ea-a13d-42010a800199
Spec:
  Appinfo:
    Appkind:              deployment
    Applabel:             app=nginx
    Appns:                test
  Chaos Service Account:  litmus
  Components:
    Monitor:
      Image:  
    Runner:
      Image:              rahulchheda1997/chaos-runner:ci
      Image Pull Policy:  Always
  Engine State:           stop
  Experiments:
    Name:  pod-delete
    Spec:
      Components:
      Rank:             0
  Job Clean Up Policy:  retain
  Monitoring:           true
Status:
  Engine Status:  stopped
  Experiments:
    Last Update Time:  2020-03-27T10:57:38Z
    Name:              pod-delete-xh4uom
    Status:            Forcefully Aborted
    Verdict:           Stopped
Events:
  Type    Reason                     Age   From            Message
  ----    ------                     ----  ----            -------
  Normal  ChaosEngineInitialized     47s   chaos-operator  engine-runner created successfully
  Normal  ExperimentDependencyCheck  44s   engine-runner   Experiment resources validated for Chaos Experiment: 'pod-delete'
  Normal  ExperimentJobCreate        39s   engine-runner   Experiment Job 'pod-delete-xh4uom' created for Chaos Experiment 'pod-delete'
  Normal  ChaosEngineStopped         8s    chaos-operator  Chaos resources deleted successfully

@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #160 into master will decrease coverage by 0.26%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
- Coverage   18.52%   18.25%   -0.27%     
==========================================
  Files           1        1              
  Lines         475      482       +7     
==========================================
  Hits           88       88              
- Misses        380      387       +7     
  Partials        7        7
Impacted Files Coverage Δ
...g/controller/chaosengine/chaosengine_controller.go 18.25% <0%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cdb62e...137e2c9. Read the comment docs.

Signed-off-by: Rahul M Chheda <rahul.chheda@mayadata.io>
@chandankumar4 chandankumar4 merged commit ebf41ba into litmuschaos:master Mar 27, 2020
rahulchheda added a commit to rahulchheda/chaos-operator that referenced this pull request Mar 31, 2020
…periments (litmuschaos#160)

* (feat) Added support to update the experiment Statuses for Aborted Experiments

* Updated the last updated time of the experimentStatuses

Signed-off-by: Rahul M Chheda <rahul.chheda@mayadata.io>
ksatchit pushed a commit that referenced this pull request Apr 1, 2020
* (feat) Added support for Custom Annotation (#177)

* (feat) Added support for Custom Annotation

Signed-off-by: Rahul M Chheda <rahul.chheda@mayadata.io>

* Added CHAOS_NAMESPACE as ENV (#153)

Signed-off-by: Rahul M Chheda <rahul.chheda@mayadata.io>

* (feat) Added failure events for ChaosEngine (#180)

* Added failure events

Signed-off-by: Rahul M Chheda <rahul.chheda@mayadata.io>

* (fix) Changed the labelSelector for monitor Service (#181)

Signed-off-by: Rahul M Chheda <rahul.chheda@mayadata.io>

* (chore) Added CodeCov Badge for Chaos-operator (#182)

Signed-off-by: Rahul M Chheda <rahul.chheda@mayadata.io>

* (feat) Added support to update the experiment Statuses for Aborted Experiments (#160)

* (feat) Added support to update the experiment Statuses for Aborted Experiments

* Updated the last updated time of the experimentStatuses

Signed-off-by: Rahul M Chheda <rahul.chheda@mayadata.io>

* Fix typo (#183)

Fix typo

Signed-off-by: MengZn <adnt587@gmail.com>

* (fix) Updated YAML's in deploy folder (#188)

* (fix) Upated files in deploy folder

Signed-off-by: Rahul M Chheda <rahul.chheda@mayadata.io>

Co-authored-by: MengZeLee <adnt587@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants