Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(unit): Adding units to the duration fields #459

Merged
merged 1 commit into from
Apr 18, 2023
Merged

chore(unit): Adding units to the duration fields #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions api/litmuschaos/v1alpha1/chaosengine_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ type ChaosEngineSpec struct {
Appinfo ApplicationParams `json:"appinfo,omitempty"`
//DefaultHealthCheck defines whether default health checks should be executed or not. It can be true or false
// default value is true
DefaultHealthCheck string `json:"defaultHealthCheck,omitempty"`
DefaultHealthCheck bool `json:"defaultHealthCheck,omitempty"`
//ChaosServiceAccount is the SvcAcc specified for chaos runner pods
ChaosServiceAccount string `json:"chaosServiceAccount"`
//Components contains the image, imagePullPolicy, arguments, and commands of runner
Expand Down Expand Up @@ -419,21 +419,21 @@ type PostMethod struct {
// RunProperty contains timeout, retry and interval for the probe
type RunProperty struct {
//ProbeTimeout contains timeout for the probe
ProbeTimeout int `json:"probeTimeout,omitempty"`
ProbeTimeout string `json:"probeTimeout,omitempty"`
// Interval contains the interval for the probe
Interval int `json:"interval,omitempty"`
Interval string `json:"interval,omitempty"`
// Retry contains the retry count for the probe
Retry int `json:"retry,omitempty"`
// Attempt contains the total attempt count for the probe
Attempt int `json:"attempt,omitempty"`
//ProbePollingInterval contains time interval, for which continuous probe should be sleep
// after each iteration
ProbePollingInterval int `json:"probePollingInterval,omitempty"`
ProbePollingInterval string `json:"probePollingInterval,omitempty"`
//InitialDelaySeconds time interval for which probe will wait before run
InitialDelaySeconds int `json:"initialDelaySeconds,omitempty"`
InitialDelay string `json:"initialDelay,omitempty"`
// EvaluationTimeout is the timeout window in which the SLO metrics
// will be fetched and will be evaluated
EvaluationTimeout int `json:"evaluationTimeout,omitempty"`
EvaluationTimeout string `json:"evaluationTimeout,omitempty"`
// StopOnFailure contains flag to stop/continue experiment execution, if probe fails
// it will stop the experiment execution, if provided true
// it will continue the experiment execution, if provided false or not provided(default case)
Expand Down
15 changes: 7 additions & 8 deletions deploy/chaos_crds.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@ spec:
# - pattern: '^delete$'
# - pattern: '^retain$'
defaultHealthCheck:
type: string
pattern: ^(true|false)$
type: boolean
appinfo:
type: object
properties:
Expand Down Expand Up @@ -2229,19 +2228,19 @@ spec:
- interval
properties:
evaluationTimeout:
type: integer
type: string
probeTimeout:
type: integer
type: string
interval:
type: integer
type: string
retry:
type: integer
attempt:
type: integer
probePollingInterval:
type: integer
initialDelaySeconds:
type: integer
type: string
initialDelay:
type: string
stopOnFailure:
type: boolean
sloProbe/inputs:
Expand Down
15 changes: 7 additions & 8 deletions deploy/crds/chaosengine_crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,7 @@ spec:
# - pattern: '^delete$'
# - pattern: '^retain$'
defaultHealthCheck:
type: string
pattern: ^(true|false)$
type: boolean
appinfo:
type: object
properties:
Expand Down Expand Up @@ -2227,19 +2226,19 @@ spec:
- interval
properties:
evaluationTimeout:
type: integer
type: string
probeTimeout:
type: integer
type: string
interval:
type: integer
type: string
retry:
type: integer
attempt:
type: integer
probePollingInterval:
type: integer
initialDelaySeconds:
type: integer
type: string
initialDelay:
type: string
stopOnFailure:
type: boolean
sloProbe/inputs:
Expand Down