Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link on what-is-litmus page #121

Closed
PratikBorhade302 opened this issue Sep 10, 2021 · 1 comment · Fixed by #122
Closed

Broken link on what-is-litmus page #121

PratikBorhade302 opened this issue Sep 10, 2021 · 1 comment · Fixed by #122

Comments

@PratikBorhade302
Copy link
Contributor

What happened:
Link for the Sign your work should be this and not this. Current link will just open the CONTRIBUTING.md

What you expected to happen:
Clicking on Sign you work should open: https://github.com/litmuschaos/litmus/blob/master/CONTRIBUTING.md#sign-your-work-with-developer-certificate-of-origin

How to reproduce it (as minimally and precisely as possible):

  • Open what-is-litmus page
  • Scroll down to the bottom
  • Click on Sign your work (Will open the correct page but the won't redirect to actual content)
@PratikBorhade302
Copy link
Contributor Author

Hi, I will submit a PR. Wait for a moment :)

(I hope developers wont fix this before I submit a PR)

PratikBorhade302 added a commit to PratikBorhade302/litmus-docs that referenced this issue Sep 10, 2021
Fix litmuschaos#121.
Clicking on Sign you work should open: https://github.com/litmuschaos/litmus/blob/master/CONTRIBUTING.md#sign-your-work-with-developer-certificate-of-origin
Presently it opens the correct GitHub page but wrong Heading is mentioned in the link

Signed-off-by: Pratik Borhade <pratikborhade302@gmail.com>
PratikBorhade302 added a commit to PratikBorhade302/litmus-docs that referenced this issue Sep 11, 2021
Fix litmuschaos#121.
Clicking on Sign you work should open: https://github.com/litmuschaos/litmus/blob/master/CONTRIBUTING.md#sign-your-work-with-developer-certificate-of-origin
Presently it opens the correct GitHub page but wrong Heading is mentioned in the link

Signed-off-by: Pratik Borhade <pratikborhade302@gmail.com>
imrajdas pushed a commit that referenced this issue Sep 14, 2021
Fix #121.
Clicking on Sign you work should open: https://github.com/litmuschaos/litmus/blob/master/CONTRIBUTING.md#sign-your-work-with-developer-certificate-of-origin
Presently it opens the correct GitHub page but wrong Heading is mentioned in the link

Signed-off-by: Pratik Borhade <pratikborhade302@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant