Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container-kill: Sending SIGTERM instead of SIGKILL when using CRIO runtime #310

Closed
radudd opened this issue Mar 8, 2021 · 2 comments
Closed

Comments

@radudd
Copy link
Contributor

radudd commented Mar 8, 2021

I am trying to use container-kill experiment with OpenShift 4 which uses CRIO 1.19 as container runtime.

Checking in the code, this experiment is triggered by executing crictl stop container-id [1]
But looking then to the underlying terminated container, I see that its exit code is 143, i.e. it receives a SIGTERM, but not a SIGKILL.
However, if I try a manual test directly from the host and I add the --timeout=0 to the crictl stop command, the container will receive a SIGKILL, i.e its exit status will be 137.
Following PR should fix this issue: #306

Many thanks!

[1]

cmd := exec.Command("crictl", "-i", endpoint, "-r", endpoint, "stop", string(containerID))

@ksatchit
Copy link
Member

ksatchit commented Mar 8, 2021

Thank you @radudd !

@radudd radudd changed the title container-kill: Sending SIGTERM instead SIGKILL when using CRIO runtime container-kill: Sending SIGTERM instead of SIGKILL when using CRIO runtime Mar 8, 2021
@radudd
Copy link
Contributor Author

radudd commented Mar 8, 2021

Many thanks for merging the PR #306.
Would it also be possible to backport it to versions 1.11 and 1.12? Thanks!

@radudd radudd closed this as completed Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants