Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hardcoded passwords #179

Closed
wants to merge 3 commits into from
Closed

Fix hardcoded passwords #179

wants to merge 3 commits into from

Conversation

Vr00mm
Copy link
Member

@Vr00mm Vr00mm commented Nov 24, 2021

Signed-off-by: Rémi ZIOLKOWSKI remi.ziolkowski-ext@pole-emploi.fr

What this PR does / why we need it:

Secrets, DB and JWT are hardcoded.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

Signed-off-by: Rémi ZIOLKOWSKI <remi.ziolkowski-ext@pole-emploi.fr>
@Vr00mm Vr00mm mentioned this pull request Nov 25, 2021
Signed-off-by: Rémi ZIOLKOWSKI <remi.ziolkowski@gmail.com>
Copy link
Member

@Jasstkn Jasstkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Could you create a feature branch in your fork? test workflow isn't running for your PR :(

@Vr00mm
Copy link
Member Author

Vr00mm commented Nov 26, 2021

Hi! Could you create a feature branch in your fork? test workflow isn't running for your PR :(

Hello @Jasstkn, I oppened a new pull request cause we cant change the source branch.
#181

@Vr00mm Vr00mm requested a review from Jasstkn November 26, 2021 09:21
@Vr00mm Vr00mm closed this Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants